Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-xmcloud] Failsafe catch for getSDK #1715

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 16, 2024

Description / Motivation

A bugfix follow up to #1712 . Adds a failsafe catch for getSDK call in CdpPageView component.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 16, 2024 17:55
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@addy-pathania addy-pathania merged commit cc3a2c1 into dev Jan 16, 2024
1 check passed
@addy-pathania addy-pathania deleted the bug/jss-1396-followup branch January 16, 2024 19:28
addy-pathania pushed a commit that referenced this pull request Jan 17, 2024
* [templates/nextjs-xmcloud] Failsafe catch for getSDK

* Changelog change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants